Создать ответ 
 
Рейтинг темы:
  • Голосов: 0 - Средняя оценка: 0
  • 1
  • 2
  • 3
  • 4
  • 5
cso support
Автор Сообщение
sundance Не на форуме
Новичок
*

Сообщений: 7
Зарегистрирован: 15.03.2020
Рейтинг: 0
Сказал спасибо: 0
Поблагодарили 0 раз(а) в 0 сообщ.
Сообщение: #4
RE: cso support
The ability to print and read traces would help a lot for debugging.
So far, I'm limited to code reviewing, which can catch a few "obvious" things, but is insufficient for serious debugging.

Anyway, having fixed a nb of minor trivial bugs in iso_loader code path, probably without visible consequences,
I've now reached a part where I suspect the *.cso related crash may lie.

Selecting a *.cso file (or any other type of image) on GUI
triggers `fs_iso_mount()`,
which, after successful loading and mounting, invokes `virt_iso_init_percd()`.
That's where it seems to go wrong for *.cso.
`virt_iso_init_percd()` invokes `get_toc_and_lba()`,
of which 2 versions exist in source code, but one is commented, hence only one is valid.
There is no explanation as to why the other version is commented out though left in the code.

Comparing these 2 versions, the code paths for *.cso look very different.

The new code invokes `get_lba_from_mki()` to determine `lba`.
If it doesn't, it unconditionally set it to 150 (a magic number without a name),
and there is this an associated comment :
// TODO: isofile_find_lba(ifs);

which looks suspicious.

This only matters if `get_lba_from_mki()` fails, but without traces, it's difficult to determine if it's what happens.

Pristine unmodified Dreamcast in perfect condition + SD Card reader on serial Port.
29.03.2020 03:54
Найти все сообщения Цитировать это сообщение
Создать ответ 


Сообщения в этой теме
cso support - sundance - 18.03.2020, 10:47
RE: cso support - kof888 - 18.03.2020, 13:42
RE: cso support - sundance - 20.03.2020, 03:31
RE: cso support - sundance - 29.03.2020 03:54
RE: cso support - SWAT - 30.03.2020, 12:41
RE: cso support - sundance2 - 24.11.2020, 20:58
RE: cso support - SWAT - 25.11.2020, 07:01
RE: cso support - sundance2 - 25.11.2020, 09:24
RE: cso support - sundance2 - 25.11.2020, 13:05
RE: cso support - SWAT - 27.11.2020, 06:54
RE: cso support - sundance2 - 27.11.2020, 23:11
RE: cso support - SWAT - 29.11.2020, 09:42

Переход:


Пользователи просматривают эту тему: 1 Гость(ей)